erki/skullc-peripherals
1
0
Fork 0
Code Issues Pull Requests Actions Projects Releases Wiki Activity

Threads: fix actor and signal requirements
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source 
Trivially copyable and default constructible should be sufficient, as it
allows for memcpy and a T{} ctor.
This commit is contained in:
Erki 2021-06-22 16:22:11 +03:00
parent f456464f6c
commit 15652f7347
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Threads/Inc/threads_actor.hpp
View File

@ -26,7 +26,7 @@ class Actor
public: public:
using value_type = T; using value_type = T;
static_assert(std::is_trivially_constructible_v<value_type>, "T must be trivially constructible."); static_assert(std::is_default_constructible_v<value_type>, "T must be default constructible.");
static_assert(std::is_trivially_copyable_v<value_type>, "T must be trivially copyable."); static_assert(std::is_trivially_copyable_v<value_type>, "T must be trivially copyable.");
Actor(const std::uint32_t queue_size, const char* name, const osPriority_t priority, const std::uint32_t stack_size) Actor(const std::uint32_t queue_size, const char* name, const osPriority_t priority, const std::uint32_t stack_size)
@ -57,7 +57,7 @@ private:
{ {
init(); init();
value_type data; value_type data{};
while (true) while (true)
{ {

3
Threads/Inc/threads_signal.hpp
View File

@ -20,7 +20,8 @@ struct Signallable
{ {
using value_type = T; using value_type = T;
static_assert(std::is_trivially_constructible_v<value_type>, "T must be trivially constructible."); static_assert(std::is_trivially_copyable_v<value_type>, "T must be trivially copyable.");
static_assert(std::is_default_constructible_v<value_type>, "T must be default constructible.");
virtual bool emit(const T& t) = 0; virtual bool emit(const T& t) = 0;
virtual std::pair<bool, BaseType_t> emitFromIsr(const T& t) = 0; virtual std::pair<bool, BaseType_t> emitFromIsr(const T& t) = 0;